Skip to content

issue fixed -Wrong order total in customer information orders tab in admin panel#18650

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
anujwebkul:anuj
Nov 6, 2018
Merged

issue fixed -Wrong order total in customer information orders tab in admin panel#18650
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
anujwebkul:anuj

Conversation

@anujwebkul
Copy link
Contributor

@anujwebkul anujwebkul commented Oct 16, 2018 •
edited
Loading

Wrong order total in customer information orders tab in admin panel.

Description (*)

Customer information orders grid's order total differs from the "orders grid", Order total (in customer information orders grid) is showing wrong if order is placed except base currency. In this pull request
I have fixed it.

Fixed Issues (if relevant)

  1. Wrong order total in customer information orders tab in admin panel #18618

Manual testing scenarios (*)

  1. Set CHF as Default Currency
  2. Set GBP currency for United Kingdom website
  3. Place order from United Kingdom website.
  4. View order total in customer information orders tab in admin panel

Finally Order total column value is showing correct in customer information orders tab.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 16, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 16, 2018

Hi @anujwebkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@anujwebkul
Copy link
Contributor Author

anujwebkul commented Oct 16, 2018

#SQUASHTOBERFEST

@rodrigowebjump rodrigowebjump self-assigned this Oct 17, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 31, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 31, 2018

Hi @sidolov, thank you for the review.
ENGCOM-3351 has been created to process this Pull Request

@sidolov sidolov mentioned this pull request Nov 6, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 11290c5 into magento:2.3-develop Nov 6, 2018
magento-engcom-team pushed a commit that referenced this pull request Nov 6, 2018
ENGCOM-3351: issue fixed -Wrong order total in customer information o…
152ae45 
…rders tab in admin panel #18650
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 6, 2018

Hi @anujwebkul. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

Labels

Award: bug fix Component: Customer Progress: accept Release Line: 2.3

Projects

None yet

Milestone

Release: 2.3.1

Development

Successfully merging this pull request may close these issues.

5 participants

@anujwebkul @magento-cicd2 @magento-engcom-team @sidolov @rodrigowebjump